Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self to raw transactions #896

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Oct 4, 2019

When distributing a raw transaction to all the recipients, it may be that there are no recipients defined.
In this PR, we add ourselves as a participant so that there is always at least 1 recipient that we can use to decrypt a payload.

No acceptance tests have been added as they should be covered by the quorum-acceptance-test suite, and no tests currently exist in this project.

Fixes #895

@codecov-io
Copy link

codecov-io commented Oct 4, 2019

Codecov Report

Merging #896 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #896      +/-   ##
===========================================
+ Coverage      99.4%   99.4%   +<.01%     
  Complexity     2093    2093              
===========================================
  Files           316     316              
  Lines          6081    6082       +1     
  Branches        312     312              
===========================================
+ Hits           6045    6046       +1     
  Misses            5       5              
  Partials         31      31
Impacted Files Coverage Δ Complexity Δ
...rum/tessera/thirdparty/RawTransactionResource.java 100% <100%> (ø) 4 <2> (ø) ⬇️
...um/tessera/transaction/TransactionManagerImpl.java 100% <100%> (ø) 37 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07066da...7456134. Read the comment docs.

@prd-fox prd-fox added 0.11 bug Something isn't working labels Oct 4, 2019
@prd-fox prd-fox merged commit c13095f into master Oct 7, 2019
@prd-fox prd-fox deleted the bugfix/add-self-to-raw-transactions branch October 7, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot send raw transactions with no other private participants
3 participants