-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jasypt encryption #845
Merged
Merged
Jasypt encryption #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namtruong
requested review from
chris-j-h,
melowe,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
August 6, 2019 10:32
Krish1979
previously approved these changes
Aug 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
============================================
- Coverage 99.47% 99.45% -0.02%
- Complexity 2067 2076 +9
============================================
Files 309 311 +2
Lines 6069 6093 +24
Branches 308 311 +3
============================================
+ Hits 6037 6060 +23
Misses 5 5
- Partials 27 28 +1
Continue to review full report at Codecov.
|
prd-fox
suggested changes
Aug 6, 2019
config/src/main/java/com/quorum/tessera/config/adapters/EncryptedStringAdapter.java
Outdated
Show resolved
Hide resolved
config/src/main/java/com/quorum/tessera/config/util/ConfigSecretReader.java
Outdated
Show resolved
Hide resolved
config/src/test/java/com/quorum/tessera/config/adapters/EncryptedStringAdapterTest.java
Outdated
Show resolved
Hide resolved
config/src/test/java/com/quorum/tessera/config/adapters/EncryptedStringAdapterTest.java
Outdated
Show resolved
Hide resolved
config/src/test/java/com/quorum/tessera/config/util/ConfigSecretReaderTest.java
Show resolved
Hide resolved
tests/acceptance-test/src/test/java/admin/cmd/StartupSteps.java
Outdated
Show resolved
Hide resolved
Fixes #846 |
prd-fox
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables jdbc password in configuration file to be obfuscated by using jasypt library for encryption/decryption.
To enable the feature simply replace plain-text property with encrypted value and have it wrapped inside
ENC()
function. I.e."password": "ENC(ujMeokIQ9UFHSuBYetfRjQTpZASgaua3)"
.For details on how to encrypt a string using jasypt binary, see Encrypt database password section below.
Please note at the moment this encryption is only enabled on
jdbc.password