Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jasypt encryption #845

Merged
merged 14 commits into from
Aug 7, 2019
Merged

Jasypt encryption #845

merged 14 commits into from
Aug 7, 2019

Conversation

namtruong
Copy link
Collaborator

@namtruong namtruong commented Aug 6, 2019

This PR enables jdbc password in configuration file to be obfuscated by using jasypt library for encryption/decryption.

  • To enable the feature simply replace plain-text property with encrypted value and have it wrapped inside ENC() function. I.e. "password": "ENC(ujMeokIQ9UFHSuBYetfRjQTpZASgaua3)".

  • For details on how to encrypt a string using jasypt binary, see Encrypt database password section below.

Please note at the moment this encryption is only enabled on jdbc.password

Krish1979
Krish1979 previously approved these changes Aug 6, 2019
@codecov-io
Copy link

codecov-io commented Aug 6, 2019

Codecov Report

Merging #845 into master will decrease coverage by 0.01%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #845      +/-   ##
============================================
- Coverage     99.47%   99.45%   -0.02%     
- Complexity     2067     2076       +9     
============================================
  Files           309      311       +2     
  Lines          6069     6093      +24     
  Branches        308      311       +3     
============================================
+ Hits           6037     6060      +23     
  Misses            5        5              
- Partials         27       28       +1
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/quorum/tessera/config/JdbcConfig.java 100% <ø> (ø) 10 <0> (ø) ⬇️
...quorum/tessera/config/util/ConfigSecretReader.java 100% <100%> (ø) 5 <5> (?)
...m/tessera/config/util/EncryptedStringResolver.java 91.66% <91.66%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62aa73...01f5b7c. Read the comment docs.

@prd-fox
Copy link
Contributor

prd-fox commented Aug 6, 2019

Fixes #846

@Krish1979 Krish1979 merged commit 552b8b8 into master Aug 7, 2019
@namtruong namtruong deleted the jasypt-encryption branch August 7, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants