Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recipient data on resend #766

Merged
merged 2 commits into from
May 29, 2019

Conversation

chris-j-h
Copy link
Collaborator

@chris-j-h chris-j-h commented May 29, 2019

This PR fixes a bug when the sender of a payload receives a resend request.

The sender must prune the payload data before resending (i.e. remove the list of recipient keys and only keep the recipient box for the key requesting the resend).

Fixes #770

@chris-j-h chris-j-h marked this pull request as ready for review May 29, 2019 11:55
@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #766 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #766      +/-   ##
============================================
+ Coverage     99.45%   99.45%   +<.01%     
  Complexity     1901     1901              
============================================
  Files           287      287              
  Lines          5652     5655       +3     
  Branches        281      281              
============================================
+ Hits           5621     5624       +3     
  Misses            5        5              
  Partials         26       26
Impacted Files Coverage Δ Complexity Δ
...um/tessera/transaction/TransactionManagerImpl.java 100% <100%> (ø) 35 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2265c52...ae01204. Read the comment docs.

@Krish1979 Krish1979 merged commit 7e61c1e into master May 29, 2019
@prd-fox prd-fox added 0.10.0 bug Something isn't working labels May 30, 2019
@chris-j-h chris-j-h deleted the fix/remove-recipient-data-on-resend branch May 30, 2019 13:02
@prd-fox prd-fox added 0.9.2 and removed 0.10.0 labels Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.9.2 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipient data not always removed on resend
5 participants