-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitoring fixes/improvements #744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-j-h
requested review from
melowe,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
May 10, 2019 20:09
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
============================================
+ Coverage 99.45% 99.45% +<.01%
Complexity 1888 1888
============================================
Files 285 285
Lines 5639 5640 +1
Branches 282 282
============================================
+ Hits 5608 5609 +1
Misses 5 5
Partials 26 26
Continue to review full report at Codecov.
|
chris-j-h
force-pushed
the
monitoring-fixes
branch
from
May 12, 2019 11:29
bd4d42d
to
6a0c925
Compare
chris-j-h
force-pushed
the
monitoring-fixes
branch
from
May 12, 2019 11:32
6a0c925
to
c9f1997
Compare
melowe
approved these changes
May 13, 2019
Linked issue: #748 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/changes for the InfluxDB and Prometheus metrics:
tessera_P2P_GET_getPartyInfo
influxConfig
only enabled monitoring for theP2P
app. BothQ2T
andP2P
apps now record metrics to InfluxDB