Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring fixes/improvements #744

Merged
merged 12 commits into from
May 13, 2019
Merged

Monitoring fixes/improvements #744

merged 12 commits into from
May 13, 2019

Conversation

chris-j-h
Copy link
Collaborator

@chris-j-h chris-j-h commented May 10, 2019

Fixes/changes for the InfluxDB and Prometheus metrics:

  • MBean query was broken after server code refactors, this has been fixed
  • It was difficult to distinguish between metrics from different app types. The AppType is now included in measurement names, e.g.tessera_P2P_GET_getPartyInfo
  • Using the deprecated server config and including influxConfig only enabled monitoring for the P2P app. Both Q2T and P2P apps now record metrics to InfluxDB

@codecov-io
Copy link

codecov-io commented May 12, 2019

Codecov Report

Merging #744 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #744      +/-   ##
============================================
+ Coverage     99.45%   99.45%   +<.01%     
  Complexity     1888     1888              
============================================
  Files           285      285              
  Lines          5639     5640       +1     
  Branches        282      282              
============================================
+ Hits           5608     5609       +1     
  Misses            5        5              
  Partials         26       26
Impacted Files Coverage Δ Complexity Δ
.../quorum/tessera/config/DeprecatedServerConfig.java 100% <100%> (ø) 19 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106884d...0d1f2f9. Read the comment docs.

@melowe melowe merged commit 0bf57b5 into master May 13, 2019
@chris-j-h chris-j-h deleted the monitoring-fixes branch May 16, 2019 10:43
@prd-fox prd-fox added 0.10.0 bug Something isn't working feature User features labels May 16, 2019
@prd-fox
Copy link
Contributor

prd-fox commented May 16, 2019

Linked issue: #748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.0 bug Something isn't working feature User features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants