Issue 649 node validation #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
melowe
commented
May 9, 2019
melowe
commented
- Validate recipients (that url) in party info message that belong to caller/sender that it has at least one valid key.
- Do not validate non sender recipients as they will be validated during their p2p dialogue.
- Update only the sender's recipients into local party info.
the sending node unencrypt.
Treat calling node not providing any valid keys as a security issue. Filter all recipients by valid key.
prefiltered before this stage
Add extra debug info if needed
This reverts commit b7e641b.
…ts or prefiltered before this stage " This reverts commit bf2d77e.
allowing them to connect.
for the url and that the recipient will be ignored.
…source.java Co-Authored-By: Peter Fox <[email protected]>
Add prefix to test suite annotations and executioncontext to allow for custom namespaces when generating files and loggers. Add inital tests for p2p changes to ensure interactions with 4 test nodes are expected.
…l contain urls in the recipient list and therefore will be validated during their p2p dialogue.
melowe
requested review from
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
============================================
+ Coverage 99.44% 99.45% +<.01%
- Complexity 1886 1888 +2
============================================
Files 285 285
Lines 5620 5639 +19
Branches 284 282 -2
============================================
+ Hits 5589 5608 +19
Misses 5 5
Partials 26 26
Continue to review full report at Codecov.
|
namtruong
approved these changes
May 10, 2019
prd-fox
approved these changes
May 10, 2019
|
Linked issue: #649 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.