Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix bouncycastle version conflict #736

Merged
merged 6 commits into from
May 7, 2019
Merged

Bugfix bouncycastle version conflict #736

merged 6 commits into from
May 7, 2019

Conversation

melowe
Copy link
Contributor

@melowe melowe commented May 7, 2019 •
edited by namtruong
Loading

Fixes #731

@codecov-io
Copy link

codecov-io commented May 7, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7e39a03). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #736   +/-   ##
=========================================
  Coverage          ?   99.44%           
  Complexity        ?     1886           
=========================================
  Files             ?      285           
  Lines             ?     5620           
  Branches          ?      284           
=========================================
  Hits              ?     5589           
  Misses            ?        5           
  Partials          ?       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e39a03...2eb5fdc. Read the comment docs.

@melowe melowe merged commit 9cbcbe1 into master May 7, 2019
@prd-fox prd-fox added 0.9 bug Something isn't working labels May 16, 2019
@namtruong namtruong deleted the bugfix-bouncycastle-version-conflict branch May 23, 2019 13:42
@Krish1979 Krish1979 added 0.9.3 and removed 0.9.3 labels Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namtruong namtruong namtruong approved these changes

@chris-j-h chris-j-h Awaiting requested review from chris-j-h chris-j-h is a code owner

@nicolae-leonte-go nicolae-leonte-go Awaiting requested review from nicolae-leonte-go

@prd-fox prd-fox Awaiting requested review from prd-fox

@SatpalSandhu61 SatpalSandhu61 Awaiting requested review from SatpalSandhu61

Assignees
No one assigned
Labels
0.9 bug Something isn't working
Projects
None yet
Milestone
No milestone
5 participants
@melowe @codecov-io @namtruong @prd-fox @Krish1979