Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override passwords to be applied to keys #723

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Apr 29, 2019

Fixes #722

Perform the application of passwords to keys after the overrides have been applied, instead of during un-marshalling of the file configuration. This will allow the password to be set correctly instead of being ignored and leading to a "missing password on key" error.

been applied, instead of during unmarshalling of the file configuration.
@codecov-io
Copy link

codecov-io commented Apr 29, 2019

Codecov Report

Merging #723 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #723      +/-   ##
============================================
- Coverage     99.48%   99.44%   -0.04%     
+ Complexity     1894     1890       -4     
============================================
  Files           286      285       -1     
  Lines          5619     5617       -2     
  Branches        285      284       -1     
============================================
- Hits           5590     5586       -4     
  Misses            5        5              
- Partials         24       26       +2
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/quorum/tessera/config/Config.java 100% <ø> (ø) 28 <0> (ø) ⬇️
...m/quorum/tessera/config/cli/DefaultCliAdapter.java 99.39% <100%> (+0.07%) 24 <6> (+6) ⬆️
...straints/EitherServerConfigsOrServerValidator.java 86.95% <0%> (-8.7%) 7% <0%> (-2%)
.../quorum/tessera/config/keypairs/InlineKeypair.java 95% <0%> (-5%) 8% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de744b2...a3fa906. Read the comment docs.

@melowe melowe merged commit 9ada92c into master Apr 29, 2019
@prd-fox prd-fox deleted the issue-722-locked-key-password-override branch April 29, 2019 14:58
@prd-fox prd-fox added 0.10.0 bug Something isn't working labels May 3, 2019
@Krish1979 Krish1979 added 0.9.3 and removed 0.10.0 labels Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.9.3 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key password overrides not applying correctly
4 participants