Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url validation when updating recipients. #717

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Add url validation when updating recipients. #717

merged 2 commits into from
Apr 26, 2019

Conversation

melowe
Copy link
Contributor

@melowe melowe commented Apr 26, 2019

When party info is received that existing key = url recipient pairs match the updated ones. This prevents attempts for malicious parties to register themselves and effectively redirect transactions to them . This is a partial fix for issues raised in #649 . Additional node registration dialogue to ensure that newly joining nodes are able to decypt as expected to be completed in separate PR.

@melowe
Copy link
Contributor Author

melowe commented Apr 26, 2019

Partially addresses concern raised in #649 . Prevent updating party info if recipient url is different from existing.

@melowe melowe marked this pull request as ready for review April 26, 2019 15:13
@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #717 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #717      +/-   ##
===========================================
+ Coverage     99.49%   99.5%   +<.01%     
- Complexity     1879    1889      +10     
===========================================
  Files           286     287       +1     
  Lines          5583    5609      +26     
  Branches        281     285       +4     
===========================================
+ Hits           5555    5581      +26     
  Misses            5       5              
  Partials         23      23
Impacted Files Coverage Δ Complexity Δ
...n/java/com/quorum/tessera/node/PartyInfoStore.java 100% <100%> (ø) 5 <3> (+2) ⬆️
...um/tessera/node/PartyInfoRecipientUpdateCheck.java 100% <100%> (ø) 8 <8> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 565ecb7...6b0c222. Read the comment docs.

@melowe melowe merged commit f4ace61 into master Apr 26, 2019
@melowe melowe deleted the issue_649 branch April 26, 2019 15:58
@prd-fox prd-fox added 0.10.0 bug Something isn't working labels Apr 29, 2019
@Krish1979 Krish1979 added 0.9.3 and removed 0.10.0 labels Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.9.3 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants