Cors domain filter #715
Merged
Cors domain filter #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
response filtering only to 3rd party server only.
# Conflicts: # jaxrs-service/src/main/java/com/quorum/tessera/api/filter/LoggingFilter.java
jersey. Add CORS filter but still pending confirmation on matching logic.
- match wildcards - match exact matches. Add defaults for additional cors configs and pass through to headers.
melowe
requested review from
chris-j-h,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
=========================================
Coverage 99.49% 99.49%
Complexity 1879 1879
=========================================
Files 287 286 -1
Lines 5583 5583
Branches 282 281 -1
=========================================
Hits 5555 5555
Misses 5 5
Partials 23 23
Continue to review full report at Codecov.
|
nicolae-leonte-go
approved these changes
Apr 26, 2019
server/jersey-server/src/main/java/com/quorum/tessera/server/JerseyServer.java
Show resolved
Hide resolved
| @@ -39,12 +53,22 @@ public void onTearDown() throws Exception { | |||
|
|
|||
| @Test | |||
| public void ping() { | |||
|
|
|||
| MultivaluedMap<String, Object> headers = new MultivaluedHashMap<>(); | |||
| headers.add("Origin", "*.acme.com"); | |||
There was a problem hiding this comment.
wow - I was not expecting wildcards in the Origin header... I would always have expected that the Origin is exactly the site name from where the script attempting the CORS request has been downloaded.
|
Linked issue: #709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes moving filter creation for common filters into jersey server module.