Exclude self from unseen parties list in SyncPoller #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbroadhurst
requested review from
chris-j-h,
melowe,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
============================================
+ Coverage 99.49% 99.49% +<.01%
- Complexity 1864 1866 +2
============================================
Files 285 285
Lines 5546 5553 +7
Branches 278 278
============================================
+ Hits 5518 5525 +7
Misses 5 5
Partials 23 23
Continue to review full report at Codecov.
|
|
Hey Peter. This changes look good, thanks for contributing! Could you fill out our CLA please? Once it's complete we can merge this change. https://github.com/jpmorganchase/cla/blob/master/cla-2016-09-01.pdf |
melowe
approved these changes
Apr 23, 2019
|
Linked issue: #725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tessera team,
In our Tessera 0.8 environments, the nodes are attempting to connect back to themselves to perform party discovery.
I suspect this is not an issue in most environments, as the HTTPS connection would normally succeed. However, if there is NAT involved the connection fails or times out - resulting in repeated entries in the log as the SyncPoller retries the connection. We don't see a functional issue, just confusing log entries.
We haven't observed this behaviour previously with Constellation.
The attached code change simply filters out the local address from the unseen parties list before it attempts to connect. It removes the connection attempts / log entries in our environments.