Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server address validation #656

Merged
merged 3 commits into from
Mar 21, 2019

Conversation

melowe
Copy link
Contributor

@melowe melowe commented Mar 12, 2019

Added validator and validations for serverConfig.serverAddress and serverConfig.bindingAddress.

@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #656 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #656      +/-   ##
===========================================
+ Coverage      99.5%   99.5%   +<.01%     
- Complexity     1836    1847      +11     
===========================================
  Files           281     282       +1     
  Lines          5487    5510      +23     
  Branches        268     274       +6     
===========================================
+ Hits           5460    5483      +23     
  Misses            5       5              
  Partials         22      22
Impacted Files Coverage Δ Complexity Δ
...n/java/com/quorum/tessera/config/ServerConfig.java 100% <ø> (ø) 23 <0> (ø) ⬇️
...era/config/constraints/ServerAddressValidator.java 100% <100%> (ø) 11 <11> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20dd6e5...872975e. Read the comment docs.

@melowe melowe merged commit 0364508 into master Mar 21, 2019
@melowe melowe deleted the improvement/config-server-address-validation branch March 21, 2019 13:04
@Krish1979 Krish1979 added 0.9 and removed in progress labels Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants