Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralise vault environment variable name definitions #651

Merged
merged 3 commits into from Mar 7, 2019
Merged

Centralise vault environment variable name definitions #651

merged 3 commits into from Mar 7, 2019

Conversation

chris-j-h
Copy link
Collaborator

Create constants for the Azure and Hashicorp environment variable names and add to EnvironmentVariables.java.

All environment variables in use by Tessera will now be contained within the same file. To change the value of one of the names, they need only be changed in this central location.

Also clean up constants naming throughout
@codecov-io
Copy link

codecov-io commented Mar 5, 2019

Codecov Report

Merging #651 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #651      +/-   ##
============================================
- Coverage     99.47%   99.47%   -0.01%     
  Complexity     1937     1937              
============================================
  Files           302      302              
  Lines          5947     5943       -4     
  Branches        283      283              
============================================
- Hits           5916     5912       -4     
  Misses            5        5              
  Partials         26       26
Impacted Files Coverage Δ Complexity Δ
...ey/vault/azure/AzureKeyVaultClientCredentials.java 100% <100%> (ø) 8 <0> (ø) ⬇️
...hashicorp/HashicorpKeyVaultServiceFactoryUtil.java 96.66% <100%> (-0.4%) 10 <6> (ø)
...a/key/vault/azure/AzureKeyVaultServiceFactory.java 92.85% <100%> (ø) 5 <1> (ø) ⬇️
...ult/hashicorp/HashicorpKeyVaultServiceFactory.java 100% <100%> (ø) 10 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4642a9...ac564fe. Read the comment docs.

@melowe melowe merged commit 9628c98 into Consensys:master Mar 7, 2019
@Krish1979 Krish1979 added 0.9 enhancement Non-user code enhancements labels Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.9 enhancement Non-user code enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants