Improvement/jetty server #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supports websockets, unix domain sockets and existing jaxrs over http. Added custom connector provider so jaxrs client can also communicate over unix domain socket, switching between http and or websockets will be a configuration detail. This initial commit ensures the unix socket transports works as expected and the existing tests run as before over http.
to runtime to avoid unintended usage.
not started jetty server instance for websocket server and rest server. Added work around for jetty's slightly ropy jsr356 support, willDecode appear not to be invoked on decoders. Added Response object and codec with dispatching logic, maintaining the current codecs as they are with the hope that this is fixed in the future.
melowe
requested review from
chris-j-h,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
============================================
+ Coverage 99.43% 99.44% +<.01%
- Complexity 1899 1915 +16
============================================
Files 298 301 +3
Lines 5865 5929 +64
Branches 277 281 +4
============================================
+ Hits 5832 5896 +64
Misses 5 5
Partials 28 28
Continue to review full report at Codecov.
|
than protocol. Added log warning when used to create server. Delete unixsocket server module.
namtruong
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use embedded Jetty as Web Server for rest over http, unix domain socket and websockets.