Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable transaction syncing by default #634

Merged
merged 1 commit into from Feb 19, 2019
Merged

Disable transaction syncing by default #634

merged 1 commit into from Feb 19, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Feb 18, 2019

Reverse the spring profile so that lost transaction syncing is off by default.

This will reduce load on a regular startup and only needs to be enabled under known conditions, in which case it can be started.

Part of #609

@codecov-io
Copy link

codecov-io commented Feb 18, 2019

Codecov Report

Merging #634 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #634   +/-   ##
=========================================
  Coverage     99.42%   99.42%           
  Complexity     1863     1863           
=========================================
  Files           289      289           
  Lines          5782     5782           
  Branches        273      273           
=========================================
  Hits           5749     5749           
  Misses            5        5           
  Partials         28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f54da...b5d6d76. Read the comment docs.

@melowe melowe merged commit 15f3cf3 into Consensys:master Feb 19, 2019
@melowe melowe deleted the disable-sync-default branch February 19, 2019 15:29
@prd-fox prd-fox added this to the 0.9 milestone Feb 21, 2019
@Krish1979 Krish1979 added 0.9 enhancement Non-user code enhancements labels Apr 9, 2019
@Krish1979 Krish1979 removed this from the 0.9 milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.9 enhancement Non-user code enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants