Enclave over WebSockets #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all enclave related config out of core into enclave api module . Add tactical workaround for handing null always sendto list in the form of a helper class.
integration test for enclave standalone.
communication to be stateful.
Encode bytearrays to base64 and provide nessesary codecs. Use json as transport format rarher than object serialisation.
codec class name as discriminator value as all values being decoded are encoded by the same object.
Leave default error handing for server errors until we require anything else.
melowe
requested review from
chris-j-h,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
============================================
- Coverage 99.45% 99.42% -0.03%
- Complexity 1731 1863 +132
============================================
Files 267 289 +22
Lines 5305 5783 +478
Branches 263 274 +11
============================================
+ Hits 5276 5750 +474
Misses 5 5
- Partials 24 28 +4
Continue to review full report at Codecov.
|
prd-fox
suggested changes
Feb 8, 2019
enclave/enclave-api/src/main/java/com/quorum/tessera/enclave/AlwaysSendToHelper.java
Outdated
Show resolved
Hide resolved
enclave/enclave-api/src/main/resources/tessera-enclave-spring.xml
Outdated
Show resolved
Hide resolved
enclave/enclave-api/src/test/java/com/quorum/tessera/enclave/AlwaysSendToHelperTest.java
Outdated
Show resolved
Hide resolved
.../enclave-websockets/src/main/java/com/jpmorgan/quorum/enclave/websockets/EnclaveAdapter.java
Show resolved
Hide resolved
...enclave-websockets/src/main/java/com/jpmorgan/quorum/enclave/websockets/EnclaveEndpoint.java
Outdated
Show resolved
Hide resolved
...enclave-websockets/src/main/java/com/jpmorgan/quorum/enclave/websockets/EnclaveEndpoint.java
Outdated
Show resolved
Hide resolved
...ave-websockets/src/main/java/com/jpmorgan/quorum/enclave/websockets/EnclaveRequestCodec.java
Outdated
Show resolved
Hide resolved
helper object. Use switch statements instead of multiple if/elses for enum values.
Krish1979
approved these changes
Feb 11, 2019
prd-fox
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently dormant module enabling the remoting of enclave over WebSockets in the same way as enclave-jaxws remotes over rest/http. EnclaveEndpointTest fires up local WebSockets server and delegates to mocked enclave instance.