Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Admin app #596

Merged
merged 1 commit into from Jan 14, 2019
Merged

Add Admin app #596

merged 1 commit into from Jan 14, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Jan 14, 2019

Adds an "Admin app" that contains API endpoints for node management resources, which may require different access settings (read: TLS) than the 3rd Party app.

Fixes #543

@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #596 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #596      +/-   ##
============================================
+ Coverage     99.48%   99.48%   +<.01%     
- Complexity     1724     1725       +1     
============================================
  Files           265      266       +1     
  Lines          5284     5289       +5     
  Branches        259      259              
============================================
+ Hits           5257     5262       +5     
  Misses            5        5              
  Partials         22       22
Impacted Files Coverage Δ Complexity Δ
.../java/com/quorum/tessera/admin/ConfigResource.java 100% <ø> (ø) 7 <0> (?)
...c/main/java/com/quorum/tessera/config/AppType.java 100% <100%> (ø) 5 <0> (ø) ⬇️
...in/java/com/quorum/tessera/admin/AdminRestApp.java 100% <100%> (ø) 1 <1> (?)
...com/quorum/tessera/config/cli/AdminCliAdapter.java 98.36% <100%> (ø) 8 <2> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0c950...929d5d2. Read the comment docs.

@Krish1979 Krish1979 merged commit f34d8ea into Consensys:master Jan 14, 2019
@Krish1979 Krish1979 deleted the admin-app branch January 14, 2019 14:17
@Krish1979 Krish1979 added the 0.8 label Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants