Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch around the logic for finding the key to decrypt a payload with #592

Merged
merged 1 commit into from Jan 9, 2019
Merged

Switch around the logic for finding the key to decrypt a payload with #592

merged 1 commit into from Jan 9, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Jan 9, 2019

Searching for the correct key to decrypt a payload with only relies in the payload object, rather than the database entity. It makes sense to only pass in the information that is needed, instead of deriving it every single attempt.

This is also to reduce the diff for a later PR for issue #579

@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #592 into master will decrease coverage by 0.41%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #592      +/-   ##
==========================================
- Coverage     99.42%    99%   -0.42%     
- Complexity     1645   1647       +2     
==========================================
  Files           254    258       +4     
  Lines          5023   5048      +25     
  Branches        249    250       +1     
==========================================
+ Hits           4994   4998       +4     
- Misses            5     26      +21     
  Partials         24     24
Impacted Files Coverage Δ Complexity Δ
...um/tessera/transaction/TransactionManagerImpl.java 100% <100%> (ø) 29 <1> (ø) ⬇️
...rum/tessera/config/util/PasswordReaderFactory.java 0% <0%> (ø) 0% <0%> (?)
...n/java/com/quorum/tessera/data/migration/Main.java 25% <0%> (ø) 1% <0%> (?)
...rum/tessera/config/util/ConsolePasswordReader.java 0% <0%> (ø) 0% <0%> (?)
...java/com/quorum/tessera/config/migration/Main.java 44.44% <0%> (ø) 1% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9edbb92...1d3a1c8. Read the comment docs.

@melowe melowe merged commit fd6eea1 into Consensys:master Jan 9, 2019
@melowe melowe deleted the stop-extra-decodes-with-decrypting branch January 9, 2019 17:53
@prd-fox prd-fox added the 0.8 label Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants