Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locked key missing password message #580

Merged
merged 2 commits into from Jan 2, 2019
Merged

Fix locked key missing password message #580

merged 2 commits into from Jan 2, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Dec 28, 2018

  • Remove unused key validation classes
  • Add token for when a password was not provided
  • Allow empty passwords to be valid

Note this also eagerly loads filesystem key files, and discards any errors that occurred. The thought process is that these errors will get picked up during validation of the config object.

Fixes #541

Add pattern for matching when a password is not provided for a locked
key
@prd-fox prd-fox changed the title Remove unused validation classes Fix locked key missing password message Dec 28, 2018
@codecov-io
Copy link

codecov-io commented Dec 28, 2018

Codecov Report

Merging #580 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #580      +/-   ##
============================================
- Coverage     99.43%   99.43%   -0.01%     
+ Complexity     1643     1636       -7     
============================================
  Files           256      254       -2     
  Lines          4991     4979      -12     
  Branches        247      245       -2     
============================================
- Hits           4963     4951      -12     
  Misses            5        5              
  Partials         23       23
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/quorum/tessera/config/KeyData.java 100% <ø> (ø) 30 <0> (ø) ⬇️
...quorum/tessera/config/adapters/KeyDataAdapter.java 97.33% <ø> (ø) 18 <0> (ø) ⬇️
.../quorum/tessera/config/keypairs/InlineKeypair.java 100% <100%> (ø) 9 <0> (+2) ⬆️
...um/tessera/config/constraints/Base64Validator.java 100% <100%> (ø) 6 <0> (+1) ⬆️
...a/com/quorum/tessera/config/JaxbConfigFactory.java 100% <100%> (ø) 12 <0> (ø) ⬇️
...rum/tessera/config/keypairs/FilesystemKeyPair.java 100% <100%> (ø) 15 <8> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0872f4f...d12b597. Read the comment docs.

@melowe melowe merged commit 9b9644d into Consensys:master Jan 2, 2019
@prd-fox prd-fox added the 0.8 label Jan 2, 2019
@prd-fox prd-fox deleted the fix-keypair-validation-errors branch January 2, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants