Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make self-send check more robust #571

Merged
merged 3 commits into from Dec 17, 2018
Merged

Make self-send check more robust #571

merged 3 commits into from Dec 17, 2018

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Dec 13, 2018

In certain cases, such as a misconfigured network, it is possible we think we are sending to ourselves but are infact not, based on the URL of the recipient. See issue #546 as an example.

Instead, the proper way of checking if we are sending to ourselves would be to check if the public key we are sending to is one of the keys that our own enclave manages.

In the case that the target URL is the same as ours, then the call will still go ahead and print what the target is (to identify misconfigured networks more easily).

@codecov-io
Copy link

codecov-io commented Dec 13, 2018

Codecov Report

Merging #571 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #571      +/-   ##
============================================
+ Coverage     99.49%   99.51%   +0.02%     
  Complexity     1481     1481              
============================================
  Files           238      238              
  Lines          4546     4547       +1     
  Branches        227      226       -1     
============================================
+ Hits           4523     4525       +2     
  Misses            2        2              
+ Partials         21       20       -1
Impacted Files Coverage Δ Complexity Δ
...orum/tessera/transaction/PayloadPublisherImpl.java 100% <100%> (+4.16%) 4 <3> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 199e544...2f83a77. Read the comment docs.

@melowe melowe merged commit 73c6646 into Consensys:master Dec 17, 2018
@prd-fox prd-fox deleted the improvement/check-self-send branch December 17, 2018 11:01
@prd-fox prd-fox added the 0.8 label Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants