Add auto create table config option #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acceptance tests to setup data. Stop creating tables using jpa. acceptance tests unpacks ddls and use PartyHelper uses script to create tables.
melowe
requested review from
chris-j-h,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
============================================
+ Coverage 99.49% 99.49% +<.01%
- Complexity 1479 1481 +2
============================================
Files 238 238
Lines 4541 4544 +3
Branches 227 227
============================================
+ Hits 4518 4521 +3
Misses 2 2
Partials 21 21
Continue to review full report at Codecov.
|
changes to end to end tests and 7node example would prove disruptive.
melowe
changed the title
|
Dependent quorum-examples PR Consensys/quorum-examples#142 |
prd-fox
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added auto create tables config option to allow backward compatibility with existing config.
Default create table in jpa config to none with aforementioned override.
Package ddls into jar for improved visibility and potential use in automated builds.