-
Notifications
You must be signed in to change notification settings - Fork 360
Add spec references, a mapping of spec to implementation #9731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
I like the idea, are there any examples of when this finds diffs that we could peek at? |
Contributor
Author
Contributor
|
nice, thats kinda cool... |
rolfyone
approved these changes
Aug 5, 2025
Contributor
rolfyone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM lets give this a go.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





PR Description
This PR adds a directory with specification references. These are used to map specification items (configs, presets, functions, etc) to client implementations (code in Teku). This is much less invasive than my original idea of adding spec tags all across the codebase. These specification references are meant to (1) help developers keep track of specification changes and (2) make it easier for third-parties (eg EF Protocol Security) to verify clients adhere to the specifications.
If there's a change (eg a file is moved or a function is renamed) the included CI check will alert developers that something needs to be fixed; fixing issues should be relatively infrequent and easy, probably just updating a filepath or search string. When updating the codebase to be compliant with the next spec version, developers will:
specrefs/.ethspecify.yml.ethspecify process --path=specrefs.git diffto see what changes were made.ethspecify check --path=specrefsto check for new spec items.This PR is marked as a draft because I have not completely mapped out all of the functions. This is taking longer than I expected. Opening this now so that I can collect feedback from the team.
PS: I got the idea for this from Lodestar!
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog