Skip to content

Introduce aggregating pool interface #9414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbenr merged 2 commits into from
May 12, 2025
Merged

Introduce aggregating pool interface #9414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37485a1
introduce aggregating pool interface
tbenr May 12, 2025
cb080e7
fix compilation
tbenr May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...java/tech/pegasys/teku/statetransition/attestation/AttestationManagerIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class AttestationManagerIntegrationTest {
new AggregateGenerator(spec, storageSystem.chainBuilder().getValidatorKeys());

private final AggregatingAttestationPool attestationPool =
new AggregatingAttestationPool(
new AggregatingAttestationPoolV1(
spec, recentChainData, new NoOpMetricsSystem(), DEFAULT_MAXIMUM_ATTESTATION_COUNT);
private final MergeTransitionBlockValidator transitionBlockValidator =
new MergeTransitionBlockValidator(spec, recentChainData);
Expand Down
5 changes: 3 additions & 2 deletions ...gasys/teku/statetransition.validation.signatures/AggregatingAttestationPoolBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
import tech.pegasys.teku.spec.schemas.SchemaDefinitionsElectra;
import tech.pegasys.teku.spec.util.DataStructureUtil;
import tech.pegasys.teku.statetransition.attestation.AggregatingAttestationPool;
import tech.pegasys.teku.statetransition.attestation.AggregatingAttestationPoolV1;
import tech.pegasys.teku.statetransition.attestation.AttestationForkChecker;
import tech.pegasys.teku.storage.client.RecentChainData;

Expand Down Expand Up @@ -107,7 +108,7 @@ public void init() throws Exception {
new HashMap<>();

this.pool =
new AggregatingAttestationPool(
new AggregatingAttestationPoolV1(
SPEC, recentChainData, new NoOpMetricsSystem(), DEFAULT_MAXIMUM_ATTESTATION_COUNT);
this.recentChainData = mock(RecentChainData.class);

Expand Down Expand Up @@ -211,7 +212,7 @@ public void getAttestationsForBlock(final Blackhole bh) {
@BenchmarkMode(Mode.AverageTime)
public void add(final Blackhole bh) {
var emptyPool =
new AggregatingAttestationPool(
new AggregatingAttestationPoolV1(
SPEC, recentChainData, new NoOpMetricsSystem(), DEFAULT_MAXIMUM_ATTESTATION_COUNT);
attestations.forEach(emptyPool::add);
}
Expand Down
Loading