Column cache for DataColumnSidecars#9409
Closed
zilm13 wants to merge 3 commits intoConsensys:dasfrom
Closed
Conversation
rolfyone
reviewed
May 11, 2025
| assertThat(res1) | ||
| .isCompleted(); // no assumptions on result: cache may or may not pick up latest changes | ||
| assertThat(addCompleteFuture1).isCompleted(); | ||
| long reads1 = db.getDbReadCounter().get(); |
Contributor
There was a problem hiding this comment.
we either need a lot of finals or to check these in the asserts
Contributor
Author
There was a problem hiding this comment.
My bad, used to do it in hacky PoC style. Right time to get better. Updated.
Contributor
Author
|
Merged in master in #9432 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
When recovering
DataColumnSidecarsfrom EL our nodes usually end up saving sidecars 2 times each, one when received from gossip and other from recovery because both actions happens simultaneously.. Moreover the order could be different at any slot.This PR addresses this issue
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog