Skip to content

Remove unnecessary blobs/proofs/commitments size check #7221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StefanBratanov merged 3 commits into from
Jun 2, 2023
Merged

Remove unnecessary blobs/proofs/commitments size check #7221

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61a45a4
Remove unnecessary blobs/proofs/commitments size check
StefanBratanov Jun 2, 2023
0b390b6
remove more unnecessary checks
StefanBratanov Jun 2, 2023
040684d
get back size checks
StefanBratanov Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 3 additions & 23 deletions ...c/src/main/java/tech/pegasys/teku/spec/logic/versions/deneb/helpers/MiscHelpersDeneb.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,19 +67,6 @@ public boolean isDataAvailable(
final Bytes32 beaconBlockRoot,
final List<KZGCommitment> kzgCommitments,
final List<BlobSidecar> blobSidecars) {
validateBlobs(slot, beaconBlockRoot, kzgCommitments, blobSidecars);
return true;
}

/**
* <a
* href="https://github.com/ethereum/consensus-specs/blob/dev/specs/deneb/fork-choice.md#validate_blobs">validate_blobs</a>
*/
private void validateBlobs(
final UInt64 slot,
final Bytes32 beaconBlockRoot,
final List<KZGCommitment> kzgCommitments,
final List<BlobSidecar> blobSidecars) {
blobSidecars.forEach(
blobSidecar -> {
checkArgument(
Expand All @@ -100,21 +87,14 @@ private void validateBlobs(
.collect(Collectors.toList());
final List<KZGProof> proofs =
blobSidecars.stream().map(BlobSidecar::getKZGProof).collect(Collectors.toList());
checkArgument(
kzgCommitments.size() == blobs.size(),
"Number of KZG commitments (%s) does not match number of blobs (%s)",
kzgCommitments.size(),
blobSidecars.size());
checkArgument(
blobs.size() == proofs.size(),
"Number of blobs (%s) does not match number of proofs (%s)",
blobs.size(),
proofs.size());

checkState(
kzg.verifyBlobKzgProofBatch(blobs, kzgCommitments, proofs),
"The blobs and KZG proofs do not correspond to the KZG commitments for slot %s and block root %s",
slot,
beaconBlockRoot);

return true;
}

/**
Expand Down