Skip to content

Updated to support 1.3.0.RC3 ref tests for capella#6846

Merged
lucassaldanha merged 4 commits intoConsensys:masterfrom
rolfyone:ref-test-rc3
Feb 22, 2023
Merged

Updated to support 1.3.0.RC3 ref tests for capella#6846
lucassaldanha merged 4 commits intoConsensys:masterfrom
rolfyone:ref-test-rc3

Conversation

@rolfyone
Copy link
Contributor

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

It is possible for a valid block to contain both a deposit and bls change for the same validator index, made the appropriate changes to allow this scenario.

Signed-off-by: Paul Harris <paul.harris@consensys.net>
@zilm13
Copy link
Contributor

zilm13 commented Feb 21, 2023

Execution payload things are fixed in my PR #6840
I'm not sure what is a best way to commit all. Both are broken being alone

…g, leaving them only skipped for pre-validation.

Revert to 1.3.0.rc2-hotfix1 for now, but compliant with rc3 except for deneb specific changes.

Signed-off-by: Paul Harris <paul.harris@consensys.net>
@rolfyone
Copy link
Contributor Author

Execution payload things are fixed in my PR #6840 I'm not sure what is a best way to commit all. Both are broken being alone

I'll make ours compliant then leave it at rc2, I tried to cherry-pick yours and it didnt look clean, so will let you deal with whatever is going on there...

@rolfyone rolfyone changed the title Updated to support 1.3.0.RC3 ref tests Updated to support 1.3.0.RC3 ref tests for capella Feb 22, 2023
@lucassaldanha lucassaldanha merged commit 3d2645b into Consensys:master Feb 22, 2023
@rolfyone rolfyone deleted the ref-test-rc3 branch February 22, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants