Make it possible to disable BLS verification for everything except Deposits#6116
Merged
Nashatyrev merged 5 commits intoConsensys:masterfrom Aug 24, 2022
Merged
Conversation
…ignatureVerifier reference
…posit-bls-verifier # Conflicts: # storage/src/test/java/tech/pegasys/teku/storage/client/RecentChainDataTest.java
Nashatyrev
force-pushed
the
feature/alter-deposit-bls-verifier
branch
from
b3821c6 to
4b3399a
Compare
ajsutton
added a commit
to ajsutton/teku
that referenced
this pull request
Sep 1, 2022
…xcept Deposits (Consensys#6116)" This reverts commit 35eb475.
ajsutton
added a commit
to ajsutton/teku
that referenced
this pull request
Sep 1, 2022
…xcept Deposits (Consensys#6116)" This reverts commit 35eb475.
Merged
2 tasks
Nashatyrev
added a commit
to Nashatyrev/teku
that referenced
this pull request
Jan 9, 2023
…posits (Consensys#6116) (cherry picked from commit 35eb475)
Nashatyrev
added a commit
to Nashatyrev/teku
that referenced
this pull request
Apr 21, 2023
…posits (Consensys#6116) (cherry picked from commit 35eb475)
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
When doing experiments it is sometimes desirable to disable BLS verification globally for performance reasons. However verifying Deposit signature is kind of special case: it is legal for a valid block to contain Deposit with invalid signature. Not being able to handle invalid deposit signature leads to consensus break.
This PR is still a bit hacky way to handle this: replace
AbstractBlockProcessor.blsVerifyDepositstatic flag withBLSSignatureVerifierreference to be able to set the verifier to the working instance even if the BLS verification is globally disabled withBLSConstants.disableBLSVerification().BTW this change reminded me that there is still pending BLS refactoring to make BLS code cleaner (also includes this issue #2716). Will try to address this in a separate PR later
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog