Enable gossip blob sidecar ref-test - #10780
Merged
Merged
Conversation
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…Helper method isCurrentTimeWithinInclusiveSlotRange Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…createGossipValidationHelper (needs review) Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…finalized checkpoint Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
… reftests-att-and-aggregate
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Contributor
|
looks ok to me, one codex observation to consider |
zilm13
reviewed
Jun 9, 2026
| finalizedCheckpoint -> | ||
| new GossipValidationHelper(spec, recentChainData, metricsSystem) { | ||
| @Override | ||
| public boolean currentFinalizedCheckpointIsAncestorOfBlock( |
Contributor
Author
There was a problem hiding this comment.
There's a test that validates against a non-canonical checkpoint, this test use a fake/non-existent finalized root to exercise the rejection rule, but Teku’s store cannot commit that because the finalized block is not present. So the override is not bypassing blob validation; it is replacing the fixture’s finalized checkpoint root while still using the live fork-choice ancestry data.
Contributor
There was a problem hiding this comment.
Please put it in comments somewhere around it because it's not like GossipBeaconAttestationTestExecutor override where you override noop logic to op, it looks like different logic to what is in prod and it should be clear, why it was done.
# Conflicts: # eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/gossip/GossipBeaconAggregateAndProofTestExecutor.java # eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/gossip/GossipTests.java # ethereum/statetransition/src/test/java/tech/pegasys/teku/statetransition/validation/Phase0AttestationValidatorTest.java
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
zilm13
previously approved these changes
Jun 12, 2026
zilm13
left a comment
zilm13
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just one comment nit
…sAncestorOfBlock Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
gfukushima
enabled auto-merge (squash)
June 15, 2026 01:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Created on top of #10770, it add a GossipBlobSidecar executor and enables the suite
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Low Risk
Changes are confined to reference tests and test visibility on a gossip wrapper; production blob validation behavior is not altered.
Overview
Enables the
networking/gossip_blob_sidecarconsensus reference suite by replacing the ignored placeholder with a newGossipBlobSidecarTestExecutor.The executor builds an in-memory chain (fork choice, block imports, optional finalized checkpoint), runs
BlobSidecarGossipValidatorthrough the sameTopicSubnetIdAwareOperationProcessorwrapper used in production when tests specify asubnet_id, and asserts accept / reject / ignore (including SAVE_FOR_FUTURE) per fixture. It handles failed setup blocks, BLS ignored specs, raw-root finalized checkpoints via a test-onlyGossipValidationHelperoverride, and loads a real KZG trusted setup only for invalid KZG proof cases.eth-reference-testsgains anetworking:eth2dependency;TopicSubnetIdAwareOperationProcessorinBlobSidecarGossipManagerispublicand@VisibleForTestingso ref tests can instantiate it.Reviewed by Cursor Bugbot for commit b4f00a9. Bugbot is set up for automated code reviews on this repo. Configure here.