Add target_gas_limit to PayloadAttributes - #10748
Merged
Merged
Conversation
rolfyone
reviewed
May 26, 2026
rolfyone
reviewed
May 26, 2026
rolfyone
left a comment
Contributor
There was a problem hiding this comment.
mostly just a nit on the test
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit f23ab2b. Configure here.
rolfyone
previously approved these changes
May 26, 2026
rolfyone
left a comment
Contributor
There was a problem hiding this comment.
that's so much better -appreciate it.
Contributor
Author
|
|
rolfyone
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Description
Implementation of ethereum/consensus-specs#5235
Part of alpha.8 spec
UPDATE: feature modifies
PayloadAttributesV4adding a new fieldtargetGasLimit. As long as Besu have not implemented it yet, we have a failingGloasUpgradeAcceptanceTestwhich uses real Besu, not a stub. We could either wait till it's included in some Besu release (it's not in develop yet too) or disable this test.Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Changes fork-choice payload attributes and EL RPC contract on the Gloas path; mis-resolved gas limits could affect block building, though defaults and tests limit blast radius.
Overview
Adds
targetGasLimitto GloasPayloadAttributesV4and threads it throughPayloadBuildingAttributes, engine JSON-RPC, andengine_forkchoiceUpdatedV4so the execution client receives the proposer鈥檚 desired gas limit on fork-choice updates.ProposersDataManagernow resolvestargetGasLimitviaProposerPreferencesManager(slot-matched proposer gas limit), else validator registration gas limit, else zero;BeaconChainControllerwires the real manager intoProposersDataManagerafter init order is fixed.Tests cover V4 serde, FcU v4 mapping, and gas-limit precedence.
GloasUpgradeAcceptanceTestis@Disableduntil Besu supports the updated payload attributes on FcU.Reviewed by Cursor Bugbot for commit 06c9125. Bugbot is set up for automated code reviews on this repo. Configure here.