Skip to content

Add target_gas_limit to PayloadAttributes - #10748

Merged
zilm13 merged 5 commits into
Consensys:masterfrom
zilm13:target-gas-limit
May 28, 2026
Merged

Add target_gas_limit to PayloadAttributes#10748
zilm13 merged 5 commits into
Consensys:masterfrom
zilm13:target-gas-limit

Conversation

@zilm13

@zilm13 zilm13 commented May 25, 2026

Copy link
Copy Markdown
Contributor

PR Description

Implementation of ethereum/consensus-specs#5235
Part of alpha.8 spec

UPDATE: feature modifies PayloadAttributesV4 adding a new field targetGasLimit. As long as Besu have not implemented it yet, we have a failing GloasUpgradeAcceptanceTest which uses real Besu, not a stub. We could either wait till it's included in some Besu release (it's not in develop yet too) or disable this test.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Medium Risk
Changes fork-choice payload attributes and EL RPC contract on the Gloas path; mis-resolved gas limits could affect block building, though defaults and tests limit blast radius.

Overview
Adds targetGasLimit to Gloas PayloadAttributesV4 and threads it through PayloadBuildingAttributes, engine JSON-RPC, and engine_forkchoiceUpdatedV4 so the execution client receives the proposer鈥檚 desired gas limit on fork-choice updates.

ProposersDataManager now resolves targetGasLimit via ProposerPreferencesManager (slot-matched proposer gas limit), else validator registration gas limit, else zero; BeaconChainController wires the real manager into ProposersDataManager after init order is fixed.

Tests cover V4 serde, FcU v4 mapping, and gas-limit precedence. GloasUpgradeAcceptanceTest is @Disabled until Besu supports the updated payload attributes on FcU.

Reviewed by Cursor Bugbot for commit 06c9125. Bugbot is set up for automated code reviews on this repo. Configure here.

@zilm13 zilm13 mentioned this pull request May 25, 2026
17 tasks

@rolfyone rolfyone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just a nit on the test

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit f23ab2b. Configure here.

rolfyone
rolfyone previously approved these changes May 26, 2026

@rolfyone rolfyone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's so much better -appreciate it.

@zilm13

zilm13 commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

GloasUpgradeAcceptanceTest is disabled, #10755 issue is created to not forget this.

@zilm13
zilm13 merged commit a1015e0 into Consensys:master May 28, 2026
82 of 83 checks passed
@zilm13
zilm13 deleted the target-gas-limit branch May 28, 2026 07:02
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants