Use MIN_SEED_LOOKAHEAD in proposer preferences - #10731
Merged
zilm13 merged 5 commits intoMay 25, 2026
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 12cc916. Configure here.
tbenr
previously approved these changes
May 22, 2026
Comment on lines
+76
to
81
| // for next-epoch duties, BlockProposalUtilFulu's | ||
| // getBlockProposalDependentRoot returns the same value, so we reuse it here. | ||
| final Bytes32 dependentRoot = proposerDuties.getDependentRoot(); | ||
|
|
||
| final ProposerPreferencesUtil preferencesUtil = spec.getProposerPreferencesUtil(epoch); | ||
|
|
Contributor
There was a problem hiding this comment.
i wander if we should assert that MIN_SEED_LOOKAHEAD is 1, so we start failing if it will ever change and we will be forced to fix it
zilm13
enabled auto-merge (squash)
May 25, 2026 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
ethereum/consensus-specs#5215
part of #10724
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Changes consensus gossip validation and checkpoint/lookahead math for proposer preferences; incorrect constants would reject valid messages or accept invalid ones.
Overview
Proposer preferences gossip validation and publishing now follow Gloas rules that use
MIN_SEED_LOOKAHEADinstead of a fixed “current or next epoch” window.In
GossipValidationHelper, separateisSlotInCurrentEpoch/isSlotInNextEpochchecks are replaced byisSlotInCurrentEpochWithMinSeedLookaheadTolerance, which accepts proposal slots whose epoch is between the current epoch and current +MIN_SEED_LOOKAHEAD.ProposerPreferencesGossipValidatoruses that helper for the IGNORE rule, loads checkpoint state atproposal_epoch - MIN_SEED_LOOKAHEAD(not always minus one), and indexesproposer_lookaheadwithMIN_SEED_LOOKAHEAD * SLOTS_PER_EPOCH + (proposal_slot % SLOTS_PER_EPOCH)when validating the proposer index.ProposerPreferencesPublisherdocuments the Gloas dependent-root formula andcheckArguments thatMIN_SEED_LOOKAHEAD == 1before reusing the proposer-duties dependent root from Fulu’sgetBlockProposalDependentRoot.Tests and specrefs are updated accordingly (
get_proposer_dependent_root#gloasmarked not needed in ethspecify).Reviewed by Cursor Bugbot for commit d104417. Bugbot is set up for automated code reviews on this repo. Configure here.