-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refine execute txn #339
Merged
Merged
+353
−1,026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: transaction version v2 does not apply * chore: lint + prettier * chore: fix default version * fix: disable state changes in account creation --------- Co-authored-by: stanleyyuen <102275989+stanleyyconsensys@users.noreply.github.com>
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
|
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
* chore: revamp estimate fee and removed unused rpc calls * fix: verify if account need upgrade or deploy does not always throw * fix: address comments * refactor: revamp sign delcare transaction * feat: match starknet.js signature in estimate fee * feat: createStructWithAdditionalProperties superstruct factory * fix: improve error message in rpc input validation * refactor: add universal details and invocations in superstruct util * refactor: add universal details and invocations in superstruct util * feat: revamped execute txn * chore: lint + prettier * fix: confirm dialog * feat: save transaction in state after execute txn * chore: lint + prettier * chore: lint + prettier * chore: add superstruct test * chore: update get-starknet interface * fix: address comments * chore: restrict tx version to v3 and v2 * fix: address further comments * fix: address further comments * refactor: rpc estimatefee test ts * chore: lint + prettier * feat: use define superstruct instead of union * fix: use row components * fix: wip * fix: getEstimatedFees * test: fixing * chore: refine estimate fee (#337) * fix: address comments * feat: conform execute input params to starknet * refactor: unit tests * fix: address comments * chore: refine execute txn (#339) * chore: refine execute txn * fix: lint error * fix: transaction version v2 does not apply (#340) * fix: transaction version v2 does not apply * chore: lint + prettier * chore: fix default version * fix: disable state changes in account creation --------- Co-authored-by: stanleyyuen <102275989+stanleyyconsensys@users.noreply.github.com> * fix: txn error * fix: tx default version should be set by starknet.js * chore: update updateAccountAsDeploy --------- Co-authored-by: khanti42 <florin.dzeladini@consensys.net> * fix: address comments --------- Co-authored-by: stanleyyuen <102275989+stanleyyconsensys@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
* chore: revamp estimate fee and removed unused rpc calls * fix: verify if account need upgrade or deploy does not always throw * fix: address comments * refactor: revamp sign delcare transaction * feat: match starknet.js signature in estimate fee * feat: createStructWithAdditionalProperties superstruct factory * fix: improve error message in rpc input validation * refactor: add universal details and invocations in superstruct util * refactor: add universal details and invocations in superstruct util * feat: revamped execute txn * chore: lint + prettier * fix: confirm dialog * feat: save transaction in state after execute txn * feat: txv3 in execute txn and send transaction ui * chore: lint + prettier * chore: lint + prettier * chore: add superstruct test * chore: update get-starknet interface * fix: address comments * chore: restrict tx version to v3 and v2 * fix: address further comments * fix: address further comments * refactor: rpc estimatefee test ts * chore: lint + prettier * feat: use define superstruct instead of union * fix: use row components * fix: wip * fix: getEstimatedFees * test: fixing * fix: finalized txv3, and fix circular dependencies in testing * ci: log level set to ALL in dev * chore: refine estimate fee (#337) * fix: address comments * feat: conform execute input params to starknet * refactor: unit tests * fix: address comments * chore: refine execute txn (#339) * chore: refine execute txn * fix: lint error * fix: transaction version v2 does not apply (#340) * fix: transaction version v2 does not apply * chore: lint + prettier * chore: fix default version * fix: disable state changes in account creation --------- Co-authored-by: stanleyyuen <102275989+stanleyyconsensys@users.noreply.github.com> * fix: txn error * fix: tx default version should be set by starknet.js * chore: update updateAccountAsDeploy --------- Co-authored-by: khanti42 <florin.dzeladini@consensys.net> * fix: address comments * fix: rollback snap utils * fix: allow create account to use txv3 * chore: lint + prettier * fix: address comments * fix: address comments, rollback --------- Co-authored-by: stanleyyuen <102275989+stanleyyconsensys@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to refine the execute txn rpc