Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine execute txn #339

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Aug 29, 2024

This PR is to refine the execute txn rpc

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner August 29, 2024 06:57
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and jonesho and removed request for a team August 29, 2024 06:57
stanleyyconsensys and others added 3 commits August 29, 2024 15:55
* fix: transaction version v2 does not apply

* chore: lint + prettier

* chore: fix default version

* fix: disable state changes in account creation

---------

Co-authored-by: stanleyyuen <102275989+stanleyyconsensys@users.noreply.github.com>
khanti42 and others added 2 commits August 30, 2024 10:47
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
19.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@khanti42 khanti42 merged commit c1a51a4 into feat/revamp-execute-txn Aug 30, 2024
14 checks passed
@khanti42 khanti42 deleted the chore/refine-execute-txn branch August 30, 2024 11:30
github-merge-queue bot pushed a commit that referenced this pull request Sep 2, 2024
* chore: revamp estimate fee and removed unused rpc calls

* fix: verify if account need upgrade or deploy does not always throw

* fix: address comments

* refactor: revamp sign delcare transaction

* feat: match starknet.js signature in estimate fee

* feat: createStructWithAdditionalProperties superstruct factory

* fix: improve error message in rpc input validation

* refactor: add universal details and invocations in superstruct util

* refactor: add universal details and invocations in superstruct util

* feat: revamped execute txn

* chore: lint + prettier

* fix: confirm dialog

* feat: save transaction in state after execute txn

* chore: lint + prettier

* chore: lint + prettier

* chore: add superstruct test

* chore: update get-starknet interface

* fix: address comments

* chore: restrict tx version to v3 and v2

* fix: address further comments

* fix: address further comments

* refactor: rpc estimatefee test ts

* chore: lint + prettier

* feat: use define superstruct instead of union

* fix: use row components

* fix: wip

* fix: getEstimatedFees

* test: fixing

* chore: refine estimate fee (#337)

* fix: address comments

* feat: conform execute input params to starknet

* refactor: unit tests

* fix: address comments

* chore: refine execute txn (#339)

* chore: refine execute txn

* fix: lint error

* fix: transaction version v2 does not apply (#340)

* fix: transaction version v2 does not apply

* chore: lint + prettier

* chore: fix default version

* fix: disable state changes in account creation

---------

Co-authored-by: stanleyyuen <102275989+stanleyyconsensys@users.noreply.github.com>

* fix: txn error

* fix: tx default version should be set by starknet.js

* chore: update updateAccountAsDeploy

---------

Co-authored-by: khanti42 <florin.dzeladini@consensys.net>

* fix: address comments

---------

Co-authored-by: stanleyyuen <102275989+stanleyyconsensys@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Sep 3, 2024
* chore: revamp estimate fee and removed unused rpc calls

* fix: verify if account need upgrade or deploy does not always throw

* fix: address comments

* refactor: revamp sign delcare transaction

* feat: match starknet.js signature in estimate fee

* feat: createStructWithAdditionalProperties superstruct factory

* fix: improve error message in rpc input validation

* refactor: add universal details and invocations in superstruct util

* refactor: add universal details and invocations in superstruct util

* feat: revamped execute txn

* chore: lint + prettier

* fix: confirm dialog

* feat: save transaction in state after execute txn

* feat: txv3 in execute txn and send transaction ui

* chore: lint + prettier

* chore: lint + prettier

* chore: add superstruct test

* chore: update get-starknet interface

* fix: address comments

* chore: restrict tx version to v3 and v2

* fix: address further comments

* fix: address further comments

* refactor: rpc estimatefee test ts

* chore: lint + prettier

* feat: use define superstruct instead of union

* fix: use row components

* fix: wip

* fix: getEstimatedFees

* test: fixing

* fix: finalized txv3, and fix circular dependencies in testing

* ci: log level set to ALL in dev

* chore: refine estimate fee (#337)

* fix: address comments

* feat: conform execute input params to starknet

* refactor: unit tests

* fix: address comments

* chore: refine execute txn (#339)

* chore: refine execute txn

* fix: lint error

* fix: transaction version v2 does not apply (#340)

* fix: transaction version v2 does not apply

* chore: lint + prettier

* chore: fix default version

* fix: disable state changes in account creation

---------

Co-authored-by: stanleyyuen <102275989+stanleyyconsensys@users.noreply.github.com>

* fix: txn error

* fix: tx default version should be set by starknet.js

* chore: update updateAccountAsDeploy

---------

Co-authored-by: khanti42 <florin.dzeladini@consensys.net>

* fix: address comments

* fix: rollback snap utils

* fix: allow create account to use txv3

* chore: lint + prettier

* fix: address comments

* fix: address comments, rollback

---------

Co-authored-by: stanleyyuen <102275989+stanleyyconsensys@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants