Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating sonarcloud project keys #18

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

onetrickwolf
Copy link
Contributor

Secret keys were updated as well in the GitHub configuration.

@onetrickwolf onetrickwolf requested a review from a team as a code owner October 3, 2022 20:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2022

[consensys_starknet-snap-starknet-snap] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.2% 85.2% Coverage
0.5% 0.5% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2022

[consensys_starknet-snap-wallet-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 23 Code Smells

0.0% 0.0% Coverage
4.4% 4.4% Duplication

Copy link
Contributor

@jonesho jonesho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@onetrickwolf onetrickwolf merged commit 7fc22c9 into main Oct 4, 2022
@onetrickwolf onetrickwolf deleted the sonarcloud-update branch October 4, 2022 16:08
wantedsystem added a commit that referenced this pull request Oct 10, 2022
* chore: serve app from /starknet (#14)

* chore: assets go into starknet folder (#15)

* feat: auto select the newly added token from the asset list (#16)

* chore: updating sonarcloud project keys (#18)

* fix: number of decimals displayed for the token amount (#19)

* feat: fixed the starknet.js version to be v4.6.x (#22)

* feat: new resources for dev.snaps.consensys.net (#20)

* fix: lambda and functions (#23)

* fix: dev snaps rework lambdas (#24)

* fix: lambda and functions

* feat: snaps staging and prod (#25)

* feat: snaps staging and prod

* chore: release main (#17)
wantedsystem added a commit that referenced this pull request Oct 25, 2022
* chore: serve app from /starknet (#14)

* chore: assets go into starknet folder (#15)

* feat: auto select the newly added token from the asset list (#16)

* chore: updating sonarcloud project keys (#18)

* fix: number of decimals displayed for the token amount (#19)

* feat: fixed the starknet.js version to be v4.6.x (#22)

* feat: new resources for dev.snaps.consensys.net (#20)

* fix: lambda and functions (#23)

* fix: dev snaps rework lambdas (#24)

* fix: lambda and functions

* feat: snaps staging and prod (#25)

* feat: snaps staging and prod

* chore: release main (#17)

* fix: Alignment of the alert component (#28)

* fix: fix alignment of the alert component

* fix: fix lint

* feat: update to use snap_getBip44Entropy (#21)

* chore: release main (#29)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Co-authored-by: Amine Harty <[email protected]>
Co-authored-by: J <[email protected]>
Co-authored-by: Julink <[email protected]>
Co-authored-by: jonesho <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants