feat: ensure txns in snap state have the same status and timestamp as… #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The improvement we made here is to always treat the txns from the Voyager as the source of truth and update the same txns found in the snap state with the same status and timestamp as that of Voyager. |
Julink-eth
approved these changes
Sep 21, 2022
wantedsystem
approved these changes
Sep 21, 2022
jonesho
deleted the
SF-396-perserve-deploy-txn-actual-timestamp-in-face-of-network-provider-failure
branch
Merged
This was referenced Jul 17, 2023
Closed
Closed
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… that of Voyager