Fix/shomei decode historical trielogs#164
Closed
garyschulte wants to merge 3 commits into
Closed
Conversation
Signed-off-by: garyschulte <garyschulte@gmail.com>
…ed overload Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
fix/shomei-decode-historical-trielogs
branch
from
ad00da8 to
be19f52
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit be19f52. Configure here.
garyschulte
force-pushed
the
fix/shomei-decode-historical-trielogs
branch
from
634dc83 to
ad00da8
Compare
2 tasks
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
fix/shomei-decode-historical-trielogs
branch
from
ad00da8 to
97a2266
Compare
Contributor
Author
|
this PR is now superseded by #165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Add a trielog decode overload that enables zktrielogs to be built against historical state. Use this overload in rollup_getVirtualZkEVMStateMerkleProofV1 when decoding trielogs from
eth_simulateV1Relates to #136
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Changes which
WorldStateStorageis consulted during trielog decoding, affecting account/storage old-value verification and virtual proof generation. Risk is mainly correctness-related for historical/virtual block processing; limited surface area but can cause decoding failures or incorrect proofs if miswired.Overview
Fixes historical/virtual trielog decoding by allowing
TrieLogLayerConverterto decode against a caller-providedWorldStateStorageinstead of always using the head state.Updates
rollup_getVirtualZkEVMStateMerkleProofV1to pass the cached parent block’sZkEvmWorldStateStoragewhen decoding theeth_simulateV1trielog, and adjusts the associated test to mock the new overload.Reviewed by Cursor Bugbot for commit 97a2266. Bugbot is set up for automated code reviews on this repo. Configure here.