Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize travis and fix flaky tests #873

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Optimize travis and fix flaky tests #873

merged 2 commits into from
Nov 6, 2019

Conversation

jbhurat
Copy link
Contributor

@jbhurat jbhurat commented Nov 5, 2019

  • Added cmd/swarm package to ignore when tests are run.
  • Removing install of osxfuse
  • Fixing flaky tests by cherry picking from go-ethereum PR#18508

@jbhurat jbhurat requested review from trung and jpmsam November 5, 2019 21:24
@jbhurat
Fix flaky tests by cherry picking from go-ethereum PR#18508
609b5a6 
Added cmd/swarm to ignore test package and removing install of osxfuse package
trung
trung approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@trung trung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This stablizes the build and improves 30%-50% in speed

@jpmsam jpmsam merged commit e1e3e4a into Consensys:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmsam jpmsam jpmsam approved these changes

@trung trung trung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbhurat @trung @jpmsam