Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions service not starting upon restart of the node #866

Merged
merged 2 commits into from
Nov 4, 2019

Conversation

vsmk98
Copy link
Contributor

@vsmk98 vsmk98 commented Oct 29, 2019

Permissions service is dependent on RPC server to be up and monitors on event published by RPC service. The event subscription is in side a go func. This sometimes results in subscription happening after the event has been published by RPC and resulting in the permission service waiting endlessly to start. Changes address the same.

#865

… in the event broadcast was completed even before the subscription was done in go func, resulting in permissions service not starting for the node.
@vsmk98 vsmk98 changed the title Permissions service not starting upon restart Permissions service not starting upon restart of the node Oct 29, 2019
Copy link
Contributor

@amalrajmani amalrajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@trung trung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpmsam jpmsam merged commit 118ccc6 into master Nov 4, 2019
@fixanoid fixanoid deleted the fix/permissions-service-notstarting branch November 5, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants