Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block sealing information to IBFT API #856

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Add block sealing information to IBFT API #856

merged 3 commits into from
Oct 29, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Oct 17, 2019

Allows retrieval from the API of:

  • who sealed a block
  • who created that block
  • the current nodes signing address (derived from the nodekey)

This data can be manually found by users from decoding extra data or from deriving the address themselves, but it is a hassle, so these are convenience functions for quick use.

@jpmsam jpmsam requested review from jbhurat and trung October 17, 2019 21:33
consensus/istanbul/backend/api.go Show resolved Hide resolved
consensus/istanbul/backend/engine.go Outdated Show resolved Hide resolved
@prd-fox
Copy link
Contributor Author

prd-fox commented Oct 18, 2019

Thanks @jbhurat, I've addressed the comments.

and fetch who minted and sealed a given block.
Copy link
Contributor

@jbhurat jbhurat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpmsam jpmsam merged commit 66d91d0 into Consensys:master Oct 29, 2019
@prd-fox prd-fox deleted the ibft-add-debug-info branch October 29, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants