Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrectly displayed CLI flags in geth usage #799

Merged
merged 4 commits into from
Aug 27, 2019
Merged

Fix incorrectly displayed CLI flags in geth usage #799

merged 4 commits into from
Aug 27, 2019

Conversation

chris-j-h
Copy link
Collaborator

Any flags not explicitly added to a flag group are appended to the last flag group defined.

Define the MISC group after the ISTANBUL group so that generic flags (e.g. --emitcheckpoints, --help) are correctly displayed as MISC OPTIONS and not ISTANBUL OPTIONS in the geth usage.

geth help before

...

MISC OPTIONS:

ISTANBUL OPTIONS:
  --istanbul.requesttimeout value  Timeout for each Istanbul round in milliseconds (default: 10000)
  --istanbul.blockperiod value     Default minimum difference between two consecutive block's timestamps in seconds (default: 1)
  --emitcheckpoints                If enabled, emit specially formatted logging checkpoints
  --help, -h                       show help

geth help after

...

ISTANBUL OPTIONS:
  --istanbul.requesttimeout value  Timeout for each Istanbul round in milliseconds (default: 10000)
  --istanbul.blockperiod value     Default minimum difference between two consecutive block's timestamps in seconds (default: 1)

MISC OPTIONS:
  --emitcheckpoints  If enabled, emit specially formatted logging checkpoints
  --help, -h         show help

@chris-j-h
Fix incorrectly displayed CLI flags in geth usage
050a0e2 
Any flags not explicitly added to a flag group are appended to the last
flag group defined.  Define the MISC group after the ISTANBUL group so
that generic flags (e.g. --emitcheckpoints, --help) are correctly
displayed as MISC OPTIONS and not ISTANBUL OPTIONS in the geth usage.
@jpmsam jpmsam merged commit f8c925c into master Aug 27, 2019
@fixanoid fixanoid deleted the fix-geth-usage branch September 12, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fixanoid fixanoid fixanoid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-j-h @fixanoid @jpmsam