VM read-only mode check: operation.writes not op.isMutating()
#798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`op.isMutating()` was added for checking mutating VM operation, but `operation.writes` should be used now as it registers all mutating ops and is consistent with upstream. Additionally, there is a new mutating opcode `CREATE2`, but `CREATE2` has not been added to the `op.isMutating()` set. The VM is in read-only mode when a private contract calls a public contract.
jpmsam
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
op.isMutating()was added for checking mutating VM operation, butoperation.writesshould be used now as it registers all mutating ops and is consistent with upstream.
Additionally there is a new op code added
CREATE2that is mutating, but has not been added to theop.isMutating()set. The VM is in read-only mode when a private contract calls a public contract.