set gcmode=archive always for Raft #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmsam
approved these changes
Jul 5, 2019
|
@jpmsam @prd-fox thanks for making this fix, exactly what we need which we were looking into but then saw this fix. I have a question though, if I have an existing Raft chain and all of the nodes are running in gcmode=full with Quorum release 2.2.3, and I upgrade the chain nodes to this release, will the chain continue to function? what happens if a gcmode=archive node finds that it's missing states older than the 128-block window? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With gcmode=full(feature introduced from quorum 2.2.0 onwards) Raft is not able to sync up when a node is restarted after crash or force kill.
This fix will set gcmode=archive always for Raft as per quorum.2.1.1