Adding signer tests for EIP155, Homestead and private tx. #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Quorum, private transactions are marked by v=37 and v=38, this means the chainId is not set in the signed transcation param `v` as it is in EIP155Singer. This also mean chainId 1 cannot be used, as it will conflict with a public transaction signed by EIP155Signer, `v=chainId * 2 + 35` and `v=chainId * 2 + 36` which for `chainId = 1` would be 37 and 38. Test uses 2 fixed keys which will resolve to the recovery bit being set to 0 and 1. 1. signing and recovering public txs with EIP155Singer and Homestead. 2. demonstrating the conflict when chainId is set to 1. 3. signing a private transaction with Homestead and recoverying with EIP155Signer. 4. signing and recovering private txs with Homestead. 5. signing and recovery failure when signed with EIP155.
jpmsam
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Quorum, private transactions are marked by v=37 and v=38,
this means the chainId is not set in the signed transcation param
vas it is in EIP155Singer. This also mean chainId 1 cannot beused, as it will conflict with a public transaction signed by
EIP155Signer,
v=chainId * 2 + 35andv=chainId * 2 + 36which for
chainId = 1would be 37 and 38.Test uses 2 fixed keys which will resolve to the recovery bit being
set to 0 and 1.
EIP155Signer.