geth upgrade 1.8.18 #639
Merged
geth upgrade 1.8.18 #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* swarm/network: Protocol bump (for chunk refactor) * swarm/network: Increase discovery and stream protocol version too * swarm/network: Increase priority queue cap
* ethdb: unified code comment style. * puppeth: it is unnecessary to alloc pre-funded to 256 addresses * Revert "puppeth: it is unnecessary to alloc pre-funded to 256 addresses" This reverts commit 5e04fbccf0b8aca85030af1779bb7a949033d9d8. * puppeth: fix comment typo * Revert "ethdb: unified code comment style." This reverts commit a581efb3f06a96fc7aec0bfae03c7b6d5a0c1a77. * cmd/puppeth: fix comment typo
* abi,signer: fix nil dereference in #17633 * signer/core: tiny typo fix in test error message
travis, Dockerfile, appveyor, build: bump to Go 1.11
…` (#16996) The argument is inclusive rather than exclusive, according to docs.
* swarm: fixed comment typo * eth: fixed comment typo * cmd/puppeth: fixed comment typo
* Bugfix #17216: evm loads prestate file properly now * code gofmted
Interpreter initialization is left to the PRs implementing them. Options for external interpreters are passed after a colon in the `--vm.ewasm` and `--vm.evm` switches.
common, core, light: add block age into info logs
les, light, params: update light client CHTs
* core, eth: fix dependency cycle * eth, miner: perfer to locally generated uncle
build/deb: upgrade launchpad PPA sources to Go 1.11 too
jpmsam
requested review from
trung,
jbhurat and
SatpalSandhu61
and removed request for
trung
jbhurat
reviewed
Feb 20, 2019
p2p/enode/node.go
Outdated
| @@ -82,6 +82,20 @@ func (n *Node) UDP() int { | |||
| return int(port) | |||
| } | |||
|
|
|||
| // RAFTPORT returns the RAFT PORT of the node | |||
| func (n *Node) RAFTPORT() int { | |||
There was a problem hiding this comment.
The method RAFTPORT() shouldn't be in CAPS
There was a problem hiding this comment.
The method name for other attributes like UPD, TCP, ID and IP in p2p/enode/node.go are all in CAPS. They are following this convention for KEY names basically. I have followed the same style to keep it consistent.
There was a problem hiding this comment.
I think the reason why UDP, TCP, IP are in CAPS because they are all acronyms and RAFTPORT is not, hence it need not be in CAPS
There was a problem hiding this comment.
alright, changed it to RaftPort
added 10 commits
February 25, 2019 14:46
SatpalSandhu61
previously approved these changes
Mar 7, 2019
jbhurat
previously approved these changes
Mar 7, 2019
params: config.go and denomination.go merged with conflicts
amalrajmani
dismissed stale reviews from jbhurat and SatpalSandhu61
via
849eca2
params: config.go and denomination.go merged with conflicts
SatpalSandhu61
approved these changes
Mar 19, 2019
jbhurat
approved these changes
Mar 19, 2019
jpmsam
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.