Fix for BAD BLOCK caused by "gas limit reached" for private contracts #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo corrected
Pull from quorum master
…t to be exceeded, leading to BAD BLOCK.
…t to be exceeded, leading to BAD BLOCK.
fixanoid
approved these changes
Dec 13, 2018
jpmsam
approved these changes
Feb 12, 2019
jimthematrix
pushed a commit
to kaleido-io/quorum
that referenced
this pull request
Mar 22, 2019
jimthematrix
added a commit
to kaleido-io/quorum
that referenced
this pull request
Mar 29, 2019
…insic gas, should use st.data which represents the hash for the private transaction, instead of data retrieved from constellation which is the private payload
jimthematrix
added a commit
to kaleido-io/quorum
that referenced
this pull request
Mar 29, 2019
Fixed a mistake during porting of Consensys#595, for calculating intrinsic gas…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue occurs if a block is minted containing a number of private contracts which use gas close to the block gasLimit. The conditions for the issue to occur are as follows:
Fix is to ensure that the extra gas used by the private contract is not subtracted from the block gas.
Note that the block gas usage will therefore be based on the public hash of the private contract (which will be consistent across all nodes).
fixes #576
Issue ticket has been closed, however the underlying issue as described above needs to be fixed to ensure the problem cannot recur (for example under heavy load with large numbers of transactions in a block).