Update signing issue for eth_sendTransactionAsync RPC call #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from upstream
Update request/response data structs to include extra fields Refactor the SendTransactionAsync method to just call the SendTransaction method in a goroutine, instead of reimplementing logic for a new transaction.
a goroutine at this point)
… bugfix/sendTransactionAsync-updates
fixanoid
approved these changes
Sep 27, 2018
when the channel is full. Now it returns immediately with an error indicating the channel is overloaded.
fixanoid
previously approved these changes
Oct 1, 2018
fixanoid
previously approved these changes
Oct 5, 2018
fixanoid
approved these changes
Oct 8, 2018
jpmsam
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eth_sendTrasactionAsync RPC call was implementing it's own logic to sign and submit a transaction to the pool, and the signing process wasn't updated for EIP-155. This meant private transactions were being incorrectly signed and got stuck in the TX pool.
It makes sense for the async version of eth_sendTransaction to do the same, but inside a goroutine so it can be executed whilst returning from the RPC call.
This PR also adds the missing required fields from the incoming message (the
restrictionfield) and the to the outgoing callback message (theidfield).