Fix consensus on private contract failure. #517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had populated the public receipt
failed
field with theresult of the transaction. This is correct for public transactions. It's
also correct for successful private transactions. But it's not correct
for failing private transactions, because their public receipt should
not indicate failure. The fix is straightforward.
Testing:
I used this contract:
After deploying the contract I sent in several failing transactions via
Watching the logs (
1.log
and2.log
), I saw theTX-ACCEPTED
eventsscroll as I sent
revertFunction
transactions. I see 10TX-ACCEPTED
events in both logs (1 for deploy and 9 tests via
sendBad
).Via extra logging, in
1.log
I see that the public receipts have status1
, whereas private receipts have status0
. In2.log
they all havestatus
1
.All nodes stayed up the whole time.
Fixes #434