EIP 155 Activation #502
Merged
EIP 155 Activation #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from upstream
enabled. This flag will not be present in Quorum version 2.0.2 or below, and if not present then it is safe to change the chain ID even after the EIP155 hard fork. On running 'geth init' to update the configuration, the flag is set and thus the regular restrictions about chaning
(we are not yet forked) then allow the chain ID to change.
been started following the changes
been started following the changes
… set-eip155-activation-flag # Conflicts: # eth/backend.go
jpmsam
reviewed
Aug 23, 2018
| return newCompatError("EIP155 fork block", c.EIP155Block, newcfg.EIP155Block) | ||
| } | ||
| if isQuorumEIP155Activated && c.ChainId!=nil && c.IsEIP155(head) && !configNumEqual(c.ChainId, newcfg.ChainId) { | ||
| return newCompatError("EIP155 chain ID", c.EIP155Block, newcfg.EIP155Block) |
There was a problem hiding this comment.
We should return the ChainId, not the EIP155Block.
jpmsam
approved these changes
Aug 23, 2018
|
Apologies for resurrecting this, but EIP155 only mentions Chain ID and not Network ID
Shouldn't this rather be just if Chain ID is 1 (and not if Network ID is 1), as per EIP155 ? |
|
Hi @coeniebeyers we also wanted to discourage using or keeping the default network ID, 1. We updated quorum's examples scripts to reflect that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of EIP 155 activation, Quorum will not support chain id 1. The following changes are done as a part of this PR