Feature/410/expose raft cluster api #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bts
suggested changes
Aug 23, 2018
jpmsam
approved these changes
Sep 7, 2018
bts
suggested changes
Sep 10, 2018
raft/api.go
Outdated
|
|
||
| func (s *PublicRaftAPI) Cluster() []*Address { | ||
| return append(s.raftService.raftProtocolManager.NodeInfo().PeerAddresses, | ||
| s.raftService.raftProtocolManager.NodeInfo().Address) |
There was a problem hiding this comment.
Can you extract s.raftService.raftProtocolManager.NodeInfo() to a local variable, and then reuse that value for accessing both PeerAddresses and Address? This is because NodeInfo() takes a lock and does a bunch of work:
bts
approved these changes
Sep 11, 2018
|
@apratt3377 thanks! @jpmsam ready to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give users the ability to see raft cluster information. raft.cluster exposes info of all the peers in the cluster (in pm.peers) including the raftId, nodeId, ip address, raft port, p2p port. This can be used to check that all raft nodes came up that were expected. Also can be used along with admin.peers to make sure the network was configured properly