prevent quorum from starting if privacy is enabled and syncmode is not full #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,7 +57,9 @@ var LightClientGPO = gasprice.Config{ | |||
|
|
|||
| // Defaults contains default settings for use on the Ethereum main net. | |||
| var Defaults = Config{ | |||
| SyncMode: downloader.FastSync, | |||
| // Quorum - make full sync the default sync mode in quorum (as opposed to upstream geth) | |||
| SyncMode: downloader.FullSync, | |||
There was a problem hiding this comment.
I think FullSync should be the default syncmode in quorum (which is arguably chosen over vanilla geth due to its privacy features).
Please comment here if you think otherwise.
antonydenyer
approved these changes
May 13, 2022
Krish1979
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent quorum from starting if privacy is enabled and syncmode is not full