Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate empty wal entries error logs in one warning #1393

Merged
merged 4 commits into from
May 12, 2022

Conversation

baptiste-b-pegasys
Copy link
Contributor

fixes #1386

@baptiste-b-pegasys baptiste-b-pegasys self-assigned this May 3, 2022
@baptiste-b-pegasys baptiste-b-pegasys changed the title remove error: trim empty wal entries consolidate empty wal entries error logs in one warning May 10, 2022
@baptiste-b-pegasys baptiste-b-pegasys marked this pull request as ready for review May 10, 2022 12:27
@baptiste-b-pegasys
Copy link
Contributor Author

I try to trim the empy entries with no success from unit tests and some acceptance tests, so I propose to consolidate the log entries to a summary.

Copy link
Contributor

@achraf17 achraf17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonydenyer antonydenyer merged commit 7466389 into Consensys:master May 12, 2022
@baptiste-b-pegasys baptiste-b-pegasys deleted the fix/raft-wal branch May 20, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Growing amount of block decoding errors
3 participants