Fix: update transitions for old config #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonydenyer
approved these changes
Apr 7, 2022
Comment on lines
+719
to
+735
| c1RecsBelowHead := 0 | ||
| for _, data := range c1.Transitions { | ||
| if data.Block.Cmp(head) <= 0 { | ||
| c1RecsBelowHead++ | ||
| } else { | ||
| break | ||
| } | ||
| } | ||
|
|
||
| c2RecsBelowHead := 0 | ||
| for _, data := range c2.Transitions { | ||
| if data.Block.Cmp(head) <= 0 { | ||
| c2RecsBelowHead++ | ||
| } else { | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
we should factorize these to a single function to avoid duplicate
|
|
||
| // validate that each past record is matching exactly. if not return error | ||
| for i := 0; i < c1RecsBelowHead; i++ { | ||
| isSameBlock := c1.Transitions[i].Block.Cmp(c2.Transitions[i].Block) != 0 |
There was a problem hiding this comment.
if it is not the same block, that means some block(s) has(ve) disappear?
should we raise an error?
| @@ -724,6 +788,11 @@ func (c *ChainConfig) CheckCompatible(newcfg *ChainConfig, height uint64, isQuor | |||
| if err != nil { | |||
| return newCompatError(err.Error(), cBlock, newCfgBlock) | |||
| } | |||
| // compare the transitions data between the old and new config | |||
| err, cBlock, newCfgBlock = isTransitionsConfigCompatible(c, newcfg, bhead) | |||
There was a problem hiding this comment.
so cBlock and newCfgBlock are used for creating a compat error, why not returning this error directly from the isTransiti...Compatible()?
also isTransi...Compatible(), I thought it would return a bool, could it be named checkCompatibilityOfConfigs()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the genesis it is possible to have a situation where the chain will continue to work but will fail when you re-sync your node.
For example:
Initialise
testQBFTBlock=100you reach block 101Change
testQBFTBlock=99restart you node and it continues from 102 ...Something happens and you need to re-sync, at block 99/100 you will have a failure/fork.