Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new genesis config attribut "ibft" and "qbft" #1357

Merged
merged 5 commits into from
Mar 14, 2022
Merged

Add new genesis config attribut "ibft" and "qbft" #1357

merged 5 commits into from
Mar 14, 2022

Conversation

achraf17
Copy link
Contributor

  • Add new attribut in the config of the genesis file
"config": {
  "qbft": {
    "blockperiodseconds": 2,
    "epochlength": 30000,
    "requesttimeoutseconds": 4
  },
  "ibft": {
    "blockperiodseconds": 2,
    "epochlength": 30000,
    "requesttimeoutseconds": 4
  }
}
  • The --istanbul.requesttimeout and --istanbul.blockperiod are deprecated

@achraf17 achraf17 assigned achraf17 and unassigned achraf17 Mar 11, 2022
Krish1979
Krish1979 approved these changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@Krish1979 Krish1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achraf17 achraf17 merged commit 11f37a7 into Consensys:master Mar 14, 2022
@achraf17 achraf17 deleted the feat/genesisBFT branch March 14, 2022 08:17
@rolandtyler rolandtyler mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonydenyer antonydenyer antonydenyer approved these changes

@Krish1979 Krish1979 Krish1979 approved these changes

@baptiste-b-pegasys baptiste-b-pegasys Awaiting requested review from baptiste-b-pegasys

@nicolae-leonte-go nicolae-leonte-go Awaiting requested review from nicolae-leonte-go

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achraf17 @antonydenyer @Krish1979